Skip to content

bpo-38870: don't put unnecessary parantheses on class declarations#20134

Merged
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-38870-class-bases
May 16, 2020
Merged

bpo-38870: don't put unnecessary parantheses on class declarations#20134
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-38870-class-bases

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented May 16, 2020 •
edited by bedevere-bot
Loading

current:

>>> ast.unparse(ast.parse("class Type: pass"))
'class Type():\n    pass'

after this PR:

>>> ast.unparse(ast.parse("class Type: pass"))
'class Type:\n    pass'
>>> ast.unparse(ast.parse("class Type(BaseType): pass"))
'class Type(BaseType):\n    pass'

https://bugs.python.org/issue38870

@isidentical isidentical requested a review from pablogsal May 16, 2020 21:49
@pablogsal pablogsal merged commit 25160cd into python:master May 16, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@isidentical @arturoescaip
bpo-38870: Don't put unnecessary parentheses on class declarations in…
c41b407 
… ast.parse (pythonGH-20134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isidentical @pablogsal @the-knights-who-say-ni @bedevere-bot