Skip to content

Comments

bpo-29590: fix stack trace for gen.throw() with yield from#19896

Merged
markshannon merged 2 commits intopython:masterfrom
cjerdonek:fix-issue-29590
Jul 9, 2020
Merged

bpo-29590: fix stack trace for gen.throw() with yield from#19896
markshannon merged 2 commits intopython:masterfrom
cjerdonek:fix-issue-29590

Conversation

@cjerdonek
Copy link
Member

@cjerdonek cjerdonek commented May 4, 2020 •
edited by bedevere-bot
Loading

This fixes the following issue: When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.

https://bugs.python.org/issue29590

cjerdonek added 2 commits May 3, 2020 21:57
@cjerdonek
Add failing test.
75baa96
@cjerdonek
bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)
8dda934 
When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
@cjerdonek cjerdonek requested a review from 1st1 as a code owner May 4, 2020 06:54
@cjerdonek cjerdonek changed the title [WIP] bpo-29590: fix stack trace for gen.throw() with yield from bpo-29590: fix stack trace for gen.throw() with yield from May 4, 2020
@markshannon
Copy link
Member

markshannon commented Jul 9, 2020

LGTM.

@markshannon markshannon merged commit 8b33961 into python:master Jul 9, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 9, 2020

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 9, 2020

@markshannon: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

bedevere-bot commented Jul 9, 2020

GH-21416 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@cjerdonek @miss-islington
bpo-29590: fix stack trace for gen.throw() with yield from (pythonGH-…
7bdcac5 
…19896)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 9, 2020

Sorry, @cjerdonek and @markshannon, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8b33961e4bc4020d8b2d5b949ad9d5c669300e89 3.8

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@cjerdonek @shihai1991
bpo-29590: fix stack trace for gen.throw() with yield from (python#19896
3d19985 
)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2020

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2020
@cjerdonek @miss-islington
bpo-29590: fix stack trace for gen.throw() with yield from (pythonGH-…
63d31bc 
…19896)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Sep 4, 2020

GH-22106 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2020

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2020

Thanks @cjerdonek for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2020

Sorry, @cjerdonek and @markshannon, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8b33961e4bc4020d8b2d5b949ad9d5c669300e89 3.8

@Mariatta
Copy link
Member

Mariatta commented Sep 4, 2020

Someone has to manually backport to the 3.8 branch. (I'm not doing it)

miss-islington added a commit that referenced this pull request Sep 4, 2020
@miss-islington @cjerdonek
bpo-29590: fix stack trace for gen.throw() with yield from (GH-19896)
e92219d 
* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <[email protected]>
@jbower-fb jbower-fb mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@markshannon markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cjerdonek @markshannon @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni @ZeroIntensity