Skip to content

bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_traverse and tp_clear#18749

Merged
pablogsal merged 1 commit intopython:masterfrom
pablogsal:bpo-39778
Mar 2, 2020
Merged

bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_traverse and tp_clear#18749
pablogsal merged 1 commit intopython:masterfrom
pablogsal:bpo-39778

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 2, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from tim-one March 2, 2020 19:22
@pablogsal pablogsal self-assigned this Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #18749 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18749     +/-   ##
=========================================
  Coverage   82.13%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      590143   584845   -5298     
  Branches    44489    44503     +14     
=========================================
- Hits       484725   480389   -4336     
+ Misses      95762    94804    -958     
+ Partials     9656     9652      -4
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 333 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2110551...3716af2. Read the comment docs.

tim-one
tim-one approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 😃

@pablogsal pablogsal merged commit 0c2b509 into python:master Mar 2, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2020

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0c2b509f9d1d3a9065bc62c2407e1dc2ed70e9c2 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2020
@pablogsal @miss-islington
bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_trave…
146fb53 
…rse and tp_clear (pythonGH-18749)

Objects do not own weak references to them directly through the __weakref__ list so these
do not need to be traversed by the GC.
(cherry picked from commit 0c2b509)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18755 is a backport of this pull request to the 3.7 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 2, 2020
@pablogsal
[3.8] bpo-39778: Don't traverse weak-reference lists OrderedDict's tp…
c0835ed 
…_traverse and tp_clear (pythonGH-18749)

Objects do not own weak references to them directly through the __weakref__ list so these
do not need to be traversed by the GC.
(cherry picked from commit 0c2b509)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2020

GH-18756 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 2, 2020
@miss-islington @pablogsal
bpo-39778: Don't traverse weak-reference lists OrderedDict's tp_trave…
69ded39 
…rse and tp_clear (GH-18749)

Objects do not own weak references to them directly through the __weakref__ list so these
do not need to be traversed by the GC.
(cherry picked from commit 0c2b509)

Co-authored-by: Pablo Galindo <[email protected]>
pablogsal added a commit that referenced this pull request Mar 2, 2020
@pablogsal
[3.8] bpo-39778: Don't traverse weak-reference lists OrderedDict's tp…
9ddcb91 
…_traverse and tp_clear (GH-18749) (GH-18756)

Objects do not own weak references to them directly through the __weakref__ list so these
do not need to be traversed by the GC.

(cherry picked from commit 0c2b509)
@pablogsal pablogsal deleted the bpo-39778 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-one tim-one tim-one approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @tim-one @the-knights-who-say-ni