[3.8] bpo-38410: Properly handle PySys_Audit() failures#18658
Merged
serhiy-storchaka merged 1 commit intopython:3.8from Mar 2, 2020
Merged
Conversation
_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter() didn't include proper error handling for their PySys_Audit() calls. Co-authored-by: Zackery Spytz <[email protected]>
0f8f13f to
926440b
Compare
Codecov Report
@@ Coverage Diff @@
## 3.8 #18658 +/- ##
===========================================
+ Coverage 79.13% 82.10% +2.96%
===========================================
Files 381 1918 +1537
Lines 172572 576877 +404305
Branches 0 43736 +43736
===========================================
+ Hits 136562 473624 +337062
- Misses 36010 93684 +57674
- Partials 0 9569 +9569
Continue to review full report at Codecov.
|
zooba
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter()
didn't include proper error handling for their PySys_Audit() calls.
Co-authored-by: Zackery Spytz [email protected]
https://bugs.python.org/issue38410