bpo-37022: Fix bug where pdb's do_p/do_pp commands swallow exceptions from repr#18180
Conversation
Lib/pdb.py
Outdated
| try: | ||
| val = self._getval(arg) | ||
| except: | ||
| return |
There was a problem hiding this comment.
Might be worth a comment that getval already emitted an error
|
This looks to me like a bugfix and seems safe to backport to 3.9 and 3.8. Clearly the intention was to just catch the exception from |
iritkatriel
added
needs backport to 3.9
needs backport to 3.10
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 084d10b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
iritkatriel
changed the title
repr with do_p/do_pppdb's do_p/do_pp commands swallow exceptions from repr
|
Irit, you can manage this by yourself, right? |
Yes. Just waiting for the bot to finish. |
|
Thanks @blueyed for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-26650 is a backport of this pull request to the 3.10 branch. |
… from repr (pythonGH-18180) (cherry picked from commit 6544b25) Co-authored-by: Daniel Hahler <[email protected]>
|
GH-26651 is a backport of this pull request to the 3.9 branch. |
… from repr (pythonGH-18180) (cherry picked from commit 6544b25) Co-authored-by: Daniel Hahler <[email protected]>
… from repr (GH-18180) (GH-26650) (cherry picked from commit 6544b25) Co-authored-by: Daniel Hahler <[email protected]>
… from repr (GH-18180) (GH-26651) (cherry picked from commit 6544b25) Co-authored-by: Daniel Hahler <[email protected]>
6 participants
Fixes https://bugs.python.org/issue37022.
https://bugs.python.org/issue37022