bpo-39353: Deprecate the binhex module#18025
bpo-39353: Deprecate the binhex module#18025vstinner merged 1 commit intopython:masterfrom vstinner:deprecate_binhex
Conversation
|
cc @tiran |
|
@serhiy-storchaka: Does you expect any issue just by marking the module as deprecated in 3.9? |
|
What is a benefit of deprecating it? This module is a high-level interface to several functions in the |
|
If deprecate the binhex module, I think that it would be better to deprecate corresponding functions in the binascii module in the same issue and PR, so it will be easier to find the original discussion. |
Ok. Let's do that. I added a second commit which deprecates the 5 related functions of the binascii module. I'm not sure about the binhex code to avoid emitting warnings on calls to deprecated binascii functions:
Let me answer on the issue instead. |
Lib/test/test_binhex.py
Outdated
There was a problem hiding this comment.
Is binhex imported in test___all__ or other tests?
There was a problem hiding this comment.
The full test suite pass with -Werror, except of test_signal which is unrelated to this PR: https://bugs.python.org/issue39424
Deprecate binhex4 and hexbin4 standards. Deprecate the binhex module and the following binascii functions: * b2a_hqx(), a2b_hqx() * rlecode_hqx(), rledecode_hqx() * crc_hqx()
|
@serhiy-storchaka: Thank you for insisting to also deprecate related binascii functions. You're right that it's more consistent. |
|
Can someone suggest an alternative to |
Deprecate binhex4 and hexbin4 standards. Deprecate the binhex module and the following binascii functions: * b2a_hqx(), a2b_hqx() * rlecode_hqx(), rledecode_hqx() * crc_hqx()
https://bugs.python.org/issue39353