bpo-39350: Remove deprecated fractions.gcd()#18021
Merged
vstinner merged 1 commit intopython:masterfrom Jan 16, 2020
vstinner:remove_fractions_gcd
Merged
bpo-39350: Remove deprecated fractions.gcd()#18021vstinner merged 1 commit intopython:masterfrom vstinner:remove_fractions_gcd
vstinner merged 1 commit intopython:masterfrom
vstinner:remove_fractions_gcd
Conversation
serhiy-storchaka
approved these changes
Jan 16, 2020
Lib/fractions.py
Outdated
Member
There was a problem hiding this comment.
Suggested change
| __all__ = ['Fraction', 'gcd'] | |
| __all__ = ['Fraction'] |
Member
Author
There was a problem hiding this comment.
Oops, good catch! fixed. I also rebased my PR to fix a conflict.
Remove fractions.gcd() function, deprecated since Python 3.5 (bpo-22486): use math.gcd() instead.
Contributor
|
numpy fails to build with Python 3.9.0a3. This seems like a CPython error. This PR removes _gcd, but it is still called in: Line 164 in 58a4054 |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Remove fractions.gcd() function, deprecated since Python 3.5 (bpo-22486): use math.gcd() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove fractions.gcd() function, deprecated since Python 3.5
(bpo-22486): use math.gcd() instead.
https://bugs.python.org/issue39350