Skip to content

bpo-38870: Implement round tripping support for typed AST#17797

Merged
pablogsal merged 2 commits intopython:masterfrom
isidentical:bpo-38870-type-comments
May 16, 2020
Merged

bpo-38870: Implement round tripping support for typed AST#17797
pablogsal merged 2 commits intopython:masterfrom
isidentical:bpo-38870-type-comments

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented Jan 2, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal self-requested a review January 2, 2020 18:21
@pablogsal pablogsal self-assigned this Jan 2, 2020
@pablogsal pablogsal added skip news docs Documentation in the Doc dir and removed docs Documentation in the Doc dir labels Jan 2, 2020
@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented Mar 1, 2020

@isidentical Can you rebase this against the latest master? Ping me when is ready and I can do another review

@isidentical isidentical force-pushed the bpo-38870-type-comments branch 3 times, most recently from ad41b63 to fd6a4e6 Compare March 2, 2020 19:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2020

Codecov Report

Merging #17797 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17797      +/-   ##
==========================================
- Coverage   82.14%   82.14%   -0.01%     
==========================================
  Files        1956     1955       -1     
  Lines      590206   584858    -5348     
  Branches    44503    44509       +6     
==========================================
- Hits       484798   480403    -4395     
+ Misses      95751    94805     -946     
+ Partials     9657     9650       -7
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89aa469...fd6a4e6. Read the comment docs.

@isidentical isidentical force-pushed the bpo-38870-type-comments branch 6 times, most recently from 50fc848 to a9bf97b Compare March 16, 2020 12:31
@isidentical
Copy link
Copy Markdown
Member Author

isidentical commented Mar 16, 2020

Rebased @pablogsal

pablogsal
pablogsal requested changes Mar 16, 2020
View reviewed changes
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 16, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical isidentical force-pushed the bpo-38870-type-comments branch 2 times, most recently from 8d1bb0a to 755f1c7 Compare May 15, 2020 18:32
@isidentical isidentical force-pushed the bpo-38870-type-comments branch from 755f1c7 to d29739f Compare May 15, 2020 18:41
@isidentical isidentical force-pushed the bpo-38870-type-comments branch from d29739f to 73d7286 Compare May 16, 2020 21:45
@pablogsal pablogsal merged commit dff92bb into python:master May 16, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@isidentical @arturoescaip
bpo-38870: Implement round tripping support for typed AST in ast.unpa…
7185cb2 
…rse (pythonGH-17797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isidentical @pablogsal @bedevere-bot @the-knights-who-say-ni