bpo-38614: Use test.support.LONG_TIMEOUT constant#17562
Merged
vstinner merged 1 commit intopython:masterfrom Dec 10, 2019
vstinner:long_timeout
Merged
bpo-38614: Use test.support.LONG_TIMEOUT constant#17562vstinner merged 1 commit intopython:masterfrom vstinner:long_timeout
vstinner merged 1 commit intopython:masterfrom
vstinner:long_timeout
Conversation
Replace hardcoded timeout constants in tests with LONG_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once. LONG_TIMEOUT is 5 minutes by default, but it can be longer depending on --timeout command line option.
pablogsal
approved these changes
Dec 10, 2019
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
I checked locally and this does not make the test suite run longer (no hanging timeout is involved in any successful test) but I assume that now if test hang, will hang 5 times more, no?
Member
Author
|
"but I assume that now if test hang, will hang 5 times more, no?" Yes, it hangs 5 times longer. But buildbots are automated, they dont waste developers time. If a test hangs 1 min or 1 hour, it is the same for me. But I care of flaky tests which only fail because a timeout is too short. We can make LONG_TIMEOUT shorter if it becomes an issue. Previously, each test had to be fine tuned :-( To be clear, if a test hangs, it is a bug 😁 |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Replace hardcoded timeout constants in tests with LONG_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once. LONG_TIMEOUT is 5 minutes by default, but it can be longer depending on --timeout command line option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded timeout constants in tests with LONG_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
LONG_TIMEOUT is 5 minutes by default, but it can be longer depending
on --timeout command line option.
https://bugs.python.org/issue38614