Skip to content

bpo-38614: Use default join_thread() timeout in tests#17559

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:join_thread
Dec 10, 2019
Merged

bpo-38614: Use default join_thread() timeout in tests#17559
vstinner merged 1 commit intopython:masterfrom
vstinner:join_thread

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Dec 10, 2019

Tests no longer pass a timeout value to join_thread() of
test.support: use the default join_thread() timeout instead
(SHORT_TIMEOUT constant of test.support).

https://bugs.python.org/issue38614

Tests no longer pass a timeout value to join_thread() of
test.support: use the default join_thread() timeout instead
(SHORT_TIMEOUT constant of test.support).
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@vstinner vstinner merged commit bbc8b79 into python:master Dec 10, 2019
@vstinner vstinner deleted the join_thread branch December 10, 2019 19:41
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Tests no longer pass a timeout value to join_thread() of
test.support: use the default join_thread() timeout instead
(SHORT_TIMEOUT constant of test.support).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants