bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant#17554
bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant#17554vstinner merged 1 commit intopython:masterfrom vstinner:loopback_timeout
Conversation
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once.
vstinner
requested review from
a team,
1st1,
asvetlov and
tiran
as code owners
|
@pablogsal: That's the first subset of changes to use the new test.support timeout constants. Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review. LOOPBACK_TIMEOUT default value is 5 seconds. This PR increases timeouts in modified tests, it doesn't reduce it. |
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review.
Thanks for the split, this makes so much easier to review the PR 🎉
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of test.support, so it's easier to ajdust this timeout for all tests at once.
4 participants
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
https://bugs.python.org/issue38614