bpo-36854: Fix refleak in subinterpreter #17331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finalize_interp_clear() now explicitly clears the codec registry and then trigger a GC collection to clear all references.
Member
Author
|
test_tracemalloc does crash while trying to free _Py_TrueStruct (Py_True). This object is supposed to be immortal, no? |
corona10
approved these changes
Nov 22, 2019
| _PyGC_CollectNoFail(); | ||
|
|
||
| /* Clear interpreter state and all thread states */ | ||
| PyInterpreterState_Clear(tstate->interp); |
Member
There was a problem hiding this comment.
IMHO, Can it be replaced by the newly declared variable?
PyInterpreterState_Clear(interp);
Member
Author
There was a problem hiding this comment.
Oh, right, interp could be used. I hesitate between adding "interp" variables or using "tstate->interp" :-) I may change this in my next PR, I already merged this once before I read your comment, sorry.
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
finalize_interp_clear() now explicitly clears the codec registry and then trigger a GC collection to clear all references.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
finalize_interp_clear() now explicitly clears the codec registry and then trigger a GC collection to clear all references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalize_interp_clear() now explicitly clears the codec registry and
then trigger a GC collection to clear all references.
https://bugs.python.org/issue36854