bpo-37499: Test various C calling conventions #15776
Conversation
|
I started this on a train, and never got to finishing it up. Unfortunately it duplicates work in GH-14795. |
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
|
The |
Adapted by Petr Viktorin from python#14795 All bugs are Petr's :)
These tests are now covered by in TestCallingConventions (and subclasses)
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
This looks good to me, I think we can go ahead and merge.
@encukou Let me know if you have any problems with the changes I pushed in d8a28ab.
Also, I had to rebase this against master to resolve a merge conflict, so you'll need to do a force pull or something equivalent if you want to push more commits.
|
@encukou: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@encukou: Status check is done, and it's a failure ❌ . |
|
@encukou: Status check is done, and it's a success ✅ . |
Since pythonGH-15776, the test no longer uses time_gmtime
Add functions with various calling conventions to `_testcapi`, expose them as module-level functions, bound methods, class methods, and static methods, and test calling them and introspecting them through GDB. https://bugs.python.org/issue37499 Co-authored-by: Jeroen Demeyer <[email protected]> Automerge-Triggered-By: @pganssle
6 participants
Add functions with various calling conventions to
_testcapi, expose them as module-level functions, bound methods, class methods, and static methods, and test calling them and introspecting them through GDB.https://bugs.python.org/issue37499
Co-authored-by: Jeroen Demeyer [email protected]
Automerge-Triggered-By: @pganssle