Skip to content

gh-152433: Windows: use CreateFile2 on Windows UWP build - #153021

Open
thexai wants to merge 2 commits into
python:mainfrom
thexai:uwp-createfile
Open

gh-152433: Windows: use CreateFile2 on Windows UWP build#153021
thexai wants to merge 2 commits into
python:mainfrom
thexai:uwp-createfile

Conversation

@thexai

@thexai thexai commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Windows: use CreateFile2 on Windows UWP build.

UWP does not support CreateFileW because it is only compatible with the Win32 desktop API.

CreateFile2 is available in all supported Windows versions (it could be used for everything) but for now created a wrapper to use only in UWP and avoid side effects or unexpected behavior changes on regular Windows builds.

UWP also needs convert absolute paths to relative paths due the security restrictions, so the wrapper solution is good because it does both things at the same time.

@thexai
thexai requested a review from FFY00 as a code owner July 4, 2026 11:39
@bedevere-app bedevere-app Bot mentioned this pull request Jul 4, 2026
Open
@thexai
thexai force-pushed the uwp-createfile branch 2 times, most recently from 0a1e0d9 to dc4ee4a Compare July 17, 2026 14:47
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 6, 2026
thexai added 2 commits November 7, 2026 09:52
@thexai
pythongh-152433: Windows: use CreateFile2 on Windows UWP build
1a0ca4e 
UWP does not support ``CreateFileW`` because it is only compatible
with the Win32 desktop API.
@thexai
Avoid define two times / duplicate code _Py_AbsolutePath_To_RelativePath
28f445c
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Nov 7, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 11, 2026
@cmaloney

cmaloney commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Please don't force push (https://devguide.python.org/getting-started/pull-request-lifecycle/index.html#don-t-force-push).

In my first high level look this seems to change behavior of existing cases which we need to separate out from "use the new function". 1-1 move is a lot simpler to get in than move and change behavior.

@thexai

thexai commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Well, for Windows Desktop is no behavior change:

CreateFileW is replaced by _Py_WinCreateFile and inside is called CreateFileW again with the same parameters.

For UWP CreateFileW calls are translated to CreateFile2 and absolute paths converted to relative paths when makes sense (e.g. loading Python modules).

The second commit is only a small refactor.

This has tested and works for Apps with embedded Python like Kodi on Xbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@cmaloney cmaloney Awaiting requested review from cmaloney cmaloney is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thexai @cmaloney