bpo-25172: Raise appropriate ImportError msg when crypt module used on Windows #15149
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Misc/NEWS.d/next/Windows/2019-08-06-18-09-18.bpo-25172.Akreij.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Windows/2019-08-06-18-09-18.bpo-25172.Akreij.rst
Outdated
Show resolved
Hide resolved
|
This looks good to me. Once the CLA is cleared it can be merged (the tag will update automatically). |
Co-Authored-By: Steve Dower <[email protected]>
|
Thanks @shireenrao for the PR, and @pfmoore for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…n Windows (pythonGH-15149) (cherry picked from commit f4e725f) Co-authored-by: shireenrao <[email protected]>
|
GH-15182 is a backport of this pull request to the 3.8 branch. |
|
Thanks for the contribution, @shireenrao! |
|
Thank you @pfmoore @zooba and @mangrisano for accepting my first PR 🙏 |
|
@zooba you added the needs-backport label here. The backport PR is awaiting merge, does it need manually merging? I'm not super familiar with what miss-islington does with backports, and what still needs to be handled manually. Also, I assume the follow-up PR with a test should be backported too? |
…n Windows (GH-15149) (cherry picked from commit f4e725f) Co-authored-by: shireenrao <[email protected]>
7 participants
https://bugs.python.org/issue25172