bpo-18049: Reintroduce platform guard in recursion limit test #15075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous PR fixed and issue with recursion in threads on macOS and completely removed the platform guard. Removing this guard broke tests on AIX, therefore reintroducing a guard that only runs this test on macOS.
Contributor
Author
|
This should fix a problem on the AIX buildbots introduced by PR 14748. |
Contributor
Author
|
@vstinner: this PR skips the failing test on all platforms except macOS, as it did before PR 14748. An alternative is to skip the test only on AIX, which is the platform where this test fails. |
Member
That's a good idea. |
Member
|
Oh. I see that the test is now fixed on AIX. That's even better :-) https://bugs.python.org/issue18049#msg348945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR fixed and issue with recursion in threads on
macOS and completely removed the platform guard. Removing this
guard broke tests on AIX, therefore reintroducing a guard that
only runs this test on macOS.
https://bugs.python.org/issue18049