Skip to content

gh-148675: Revert GH-146237 and GH-146241#148674

Closed
skirpichev wants to merge 3 commits intopython:mainfrom
skirpichev:revert-146237and146241
Closed

gh-148675: Revert GH-146237 and GH-146241#148674
skirpichev wants to merge 3 commits intopython:mainfrom
skirpichev:revert-146237and146241

Conversation

@skirpichev
Copy link
Copy Markdown
Member

@skirpichev skirpichev commented Apr 17, 2026

@skirpichev skirpichev marked this pull request as ready for review April 17, 2026 11:52
@skirpichev skirpichev requested a review from AA-Turner as a code owner April 17, 2026 11:52
@skirpichev skirpichev changed the title Revert PR 146237 and PR 146241 gh-148675: Revert PR 146237 and PR 146241 Apr 17, 2026
@picnixz picnixz changed the title gh-148675: Revert PR 146237 and PR 146241 gh-148675: Revert GH-146237 and GH-146241 Apr 19, 2026
@skirpichev skirpichev requested review from encukou, hugovk and vstinner May 4, 2026 10:42
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 4, 2026

I merged my change PR gh-148676 which adds Zf/Zd formats to array, ctypes, memoryview and struct. It created many conflicts with this PR.

So I created PR gh-149368 to remove F and D formats from array and memoryview: it's similar to this change but it leaves Zf/Zd in place.

@skirpichev skirpichev closed this May 4, 2026
@skirpichev skirpichev deleted the revert-146237and146241 branch May 4, 2026 15:04
@skirpichev
Copy link
Copy Markdown
Member Author

I merged my change PR #148676

Shouldn't this be approved by some other core developer?

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 4, 2026

Usually, yes, I prefer to wait for an approval of another core dev. In this case, I rushed to merge the PR to make sure that it lands into Python 3.15 alpha1. I don't like working under pressure like that. I hope that we will time to digest these changes and cleanup the code and the doc before Python 3.15 final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants