Skip to content

bpo-20443: Fix calculate_program_full_path() warning#14446

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:getpath_isabs
Jun 28, 2019
Merged

bpo-20443: Fix calculate_program_full_path() warning#14446
vstinner merged 1 commit intopython:masterfrom
vstinner:getpath_isabs

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Jun 28, 2019

Don't call _Py_isabs() with a bytes string (char*), the function
expects as wide string.

https://bugs.python.org/issue20443

Don't call _Py_isabs() with a bytes string (char*), the function
expects as wide string.
@vstinner
Copy link
Copy Markdown
Member Author

cc @tirkarthi

@vstinner
Copy link
Copy Markdown
Member Author

I don't see any compiler warning on getpath.c compilation in the macOS job of Travis CI, whereas I saw it in a previous job.

@vstinner vstinner merged commit 3029035 into python:master Jun 28, 2019
@vstinner vstinner deleted the getpath_isabs branch June 28, 2019 14:49
@tirkarthi
Copy link
Copy Markdown
Member

Thanks Victor, I can confirm that this fixes the compiler warning.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
Don't call _Py_isabs() with a bytes string (char*), the function
expects as wide string.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Don't call _Py_isabs() with a bytes string (char*), the function
expects as wide string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants