Skip to content

gh-143553: Add support for parametrized resources in regrtests#143554

Merged
serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka:test-resources-values
Jan 8, 2026
Merged

gh-143553: Add support for parametrized resources in regrtests#143554
serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka:test-resources-values

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 8, 2026 •
edited by github-actions bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 8, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 8, 2026
Closed
vstinner
vstinner approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm not really convinced that test_xpickle justify adding this complexity (-u xpickle would be enough), but I'm not strongly against this feature.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jan 8, 2026

-u xpickle enables it for all available Python versions. On my computer it will run about half a hour. With -u xpickle=... I can test only specified version. Previously, I just edited the source code, but this was inconvenient and there was risk to commit temporary modified code.

#65784 is other issue where I need to edit the source codes to run tests with special configuration.

@serhiy-storchaka serhiy-storchaka merged commit c07e5ec into python:main Jan 8, 2026
55 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 8, 2026

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2026
@serhiy-storchaka @miss-islington
pythongh-143553: Add support for parametrized resources in regrtests (p…
cf1c490 
…ythonGH-143554)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
(cherry picked from commit c07e5ec)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka deleted the test-resources-values branch January 8, 2026 11:51
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2026

GH-143555 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2026
@serhiy-storchaka @miss-islington
pythongh-143553: Add support for parametrized resources in regrtests (p…
62a99a7 
…ythonGH-143554)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
(cherry picked from commit c07e5ec)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 8, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2026

GH-143556 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 8, 2026
@bedevere-bot
Copy link

bedevere-bot commented Jan 8, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit c07e5ec.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/12487) and take a look at the build logs.
  4. Check if the failure is related to this commit (c07e5ec) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/12487

Failed tests:

  • test_urllib2net

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 21, done.        
remote: Counting objects:   4% (1/21)        
remote: Counting objects:   9% (2/21)        
remote: Counting objects:  14% (3/21)        
remote: Counting objects:  19% (4/21)        
remote: Counting objects:  23% (5/21)        
remote: Counting objects:  28% (6/21)        
remote: Counting objects:  33% (7/21)        
remote: Counting objects:  38% (8/21)        
remote: Counting objects:  42% (9/21)        
remote: Counting objects:  47% (10/21)        
remote: Counting objects:  52% (11/21)        
remote: Counting objects:  57% (12/21)        
remote: Counting objects:  61% (13/21)        
remote: Counting objects:  66% (14/21)        
remote: Counting objects:  71% (15/21)        
remote: Counting objects:  76% (16/21)        
remote: Counting objects:  80% (17/21)        
remote: Counting objects:  85% (18/21)        
remote: Counting objects:  90% (19/21)        
remote: Counting objects:  95% (20/21)        
remote: Counting objects: 100% (21/21)        
remote: Counting objects: 100% (21/21), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 21 (delta 15), reused 20 (delta 15), pack-reused 0 (from 0)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to 'c07e5ec0a9e5843fc39dec6aa94172faf6354858'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at c07e5ec0a9e gh-143553: Add support for parametrized resources in regrtests (GH-143554)
Switched to and reset branch 'main'

make: *** [buildbottest] Error 2

serhiy-storchaka added a commit that referenced this pull request Jan 8, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-143553: Add support for parametrized resources in regrtests (…
335c83e 
…GH-143554) (GH-143555)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
(cherry picked from commit c07e5ec)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jan 8, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-143553: Add support for parametrized resources in regrtests (…
cb42565 
…GH-143554) (GH-143556)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
(cherry picked from commit c07e5ec)

Co-authored-by: Serhiy Storchaka <[email protected]>
reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
@serhiy-storchaka @reidenong
pythongh-143553: Add support for parametrized resources in regrtests (p…
096ed6c 
…ythonGH-143554)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @thunder-coding
pythongh-143553: Add support for parametrized resources in regrtests (p…
ec25950 
…ythonGH-143554)

For example, "-u xpickle=2.7" will run test_xpickle only against Python 2.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @bedevere-bot @vstinner