gh-141707: Fix tarfile type corruption with GNU long names#143157
Open
heathdutton wants to merge 1 commit intopython:mainfrom
Open
gh-141707: Fix tarfile type corruption with GNU long names#143157heathdutton wants to merge 1 commit intopython:mainfrom
heathdutton wants to merge 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
When processing GNU long name headers, the name field in the second header contains garbage data. The V7 directory detection logic in frombuf() would incorrectly mark regular files as directories if this garbage ended with '/'. Re-apply the detection after patching the actual long name to correct any type corruption.
heathdutton
force-pushed
the
gh-141707-fix-tarfile-gnulong
branch
from
8e61d0b to
5186da2
Compare
Member
|
I think we should add a test for this to ensure it has been fixed and that we won’t break it in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing GNU long name headers, tarfile reads the actual name from data blocks but the second header's name field contains garbage. The V7 directory detection in frombuf() could incorrectly mark regular files as directories if this garbage ended with '/'.
This fix re-applies the V7 directory detection after patching the actual long name, correcting any type corruption caused by the garbage name data.
Fixes #141707