[3.14] gh-142206: multiprocessing.resource_tracker: Decode messages using older protocol (GH-142215) #142285
Conversation
…ages using older protocol (pythonGH-142215) (cherry picked from commit 4172644) Co-authored-by: Petr Viktorin <[email protected]>
|
@hugovk This backport should be ready to merge, maybe you want to do a quick sanity check? |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I just have a minor coding style suggestion.
| except Exception as e: | ||
| raise ValueError("malformed resource_tracker message: %r" % (line,)) from e |
There was a problem hiding this comment.
| except Exception as e: | |
| raise ValueError("malformed resource_tracker message: %r" % (line,)) from e | |
| except Exception as exc: | |
| raise ValueError("malformed resource_tracker message: %r" % (line,)) from exc |
Same suggestion for the similar try/except below.
There was a problem hiding this comment.
I didn't see this message; I merged at the same time you sent it :(
Anyway, I wouldn't change style in a backport.
(Also note that this part of the code was moved -- see git show --color-moved --color-moved-ws=allow-indentation-change f130b06da or a fancy Git client.)
There was a problem hiding this comment.
No problem. It just was a minor suggestion.
github-project-automation
bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ages using older protocol (pythonGH-142215) (pythonGH-142285) (cherry picked from commit 4172644) Difference from the original commit: the default in 3.14 is to use the simpler original protocol (except for filenames with newlines). (cherry picked from commit f130b06) Co-authored-by: Petr Viktorin <[email protected]>
|
GH-142287 is a backport of this pull request to the 3.13 branch. |
…sing older protocol (GH-142215) (#142287) [3.14] gh-142206: multiprocessing.resource_tracker: Decode messages using older protocol (GH-142215) (GH-142285) (cherry picked from commit 4172644) Difference from the original commit: the default in 3.14 is to use the simpler original protocol (except for filenames with newlines). (cherry picked from commit f130b06) Co-authored-by: Petr Viktorin <[email protected]>
3 participants
(cherry picked from commit 4172644)
In 3.14, send messages the simpler original protocol by default (that is: except for filenames with newlines).