Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Dec 3, 2025

  • Add ability to send messages in the older protocol (for testing, and possibly backports)
  • On read, decode both formats
  • Use only the first and last colons when decoding older messages
  • Filenames with newlines are always sent the new way (they'd break with the older protocol anyway)

@encukou encukou enabled auto-merge (squash) December 3, 2025 12:39
@encukou encukou merged commit 4172644 into python:main Dec 3, 2025
157 of 163 checks passed
@encukou encukou deleted the resource-tracker-format-compat branch December 3, 2025 13:01
befeleme pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2025
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Dec 5, 2025
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4172644d78d58189e46424af0aea302b1d78e2de 3.14

encukou added a commit to encukou/cpython that referenced this pull request Dec 5, 2025
…ages using older protocol (pythonGH-142215)

(cherry picked from commit 4172644)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2025

GH-142285 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 5, 2025
encukou added a commit that referenced this pull request Dec 5, 2025
…sing older protocol (GH-142215) (GH-142285)

(cherry picked from commit 4172644)

Difference from the original commit: the default in 3.14 is to use
the simpler original protocol (except for filenames with newlines).

Co-authored-by: Petr Viktorin <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2025
…ages using older protocol (pythonGH-142215) (pythonGH-142285)

(cherry picked from commit 4172644)

Difference from the original commit: the default in 3.14 is to use
the simpler original protocol (except for filenames with newlines).
(cherry picked from commit f130b06)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2025

GH-142287 is a backport of this pull request to the 3.13 branch.

Yhg1s pushed a commit that referenced this pull request Dec 5, 2025
…sing older protocol (GH-142215) (#142287)

[3.14] gh-142206: multiprocessing.resource_tracker: Decode messages using older protocol (GH-142215) (GH-142285)

(cherry picked from commit 4172644)

Difference from the original commit: the default in 3.14 is to use
the simpler original protocol (except for filenames with newlines).
(cherry picked from commit f130b06)

Co-authored-by: Petr Viktorin <[email protected]>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants