Skip to content

[3.14] gh-119452: Block until data is read #142176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugovk wants to merge 1 commit into from
Closed

[3.14] gh-119452: Block until data is read #142176

hugovk wants to merge 1 commit into from
+1 −1

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 2, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 2, 2025
Open
@hugovk
Copy link
Member Author

hugovk commented Dec 2, 2025

!buildbot AMD64 Windows11 Non-Debug

@bedevere-bot
Copy link

bedevere-bot commented Dec 2, 2025

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 56a1e65 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142176%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 Windows11 Non-Debug

The builders matched are:

  • AMD64 Windows11 Non-Debug PR

@hugovk hugovk mentioned this pull request Dec 2, 2025
Merged
encukou
encukou reviewed Dec 2, 2025
View reviewed changes
Lib/http/server.py
cursize = 0
data = self.rfile.read(min(nbytes, _MIN_READ_BUF_SIZE))
while (len(data) < nbytes and len(data) != cursize and
select.select([self.rfile._sock], [], [], 0)[0]):
Copy link
Member

@encukou encukou Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the current docs this should be omitted.
It might be better to document what None does: #142177

@hugovk
Copy link
Member Author

hugovk commented Dec 2, 2025

Windows builds are timing out on GitHub Actions:

test_large_content_length_truncated (test.test_httpservers.CGIHTTPServerTestCase.test_large_content_length_truncated) ... Timeout (0:10:00)!

https://github.com/python/cpython/actions/runs/19851448458/job/56879004094?pr=142176

encukou added a commit to encukou/cpython that referenced this pull request Dec 2, 2025
@encukou
[3.14] pythongh-142176: Read/write CGI data using worker threads
a773018 
This reads/writes data as available, making the CGI application
responsible for managing any timeouts when receiving data from
clients.

Data is read in chunks of bounded size, and passed on immediately
(except stderr, which is combined into a single message as before).
This does need 3 threads. (As does process.communicate.)
@hugovk
Copy link
Member Author

hugovk commented Dec 2, 2025

Closing in favour of a revert for 3.14.1: #142184.

And we have #142181 and #142185 to consider after that.

@hugovk hugovk closed this Dec 2, 2025
@hugovk hugovk deleted the 3.14-http-server-block-indefinitely branch December 2, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @bedevere-bot @encukou