gh-141004: Document missing generator APIs #141409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
needs backport to 3.13
bedevere-app
bot
added
awaiting core review
docs
vstinner
approved these changes
Nov 20, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, I just have minor suggestions.
| .. c:function:: int PyAsyncGen_CheckExact(PyObject *op) | ||
| Return true if *op* is an asynchronous generator object, false otherwise. |
Member
There was a problem hiding this comment.
Suggested change
| Return true if *op* is an asynchronous generator object, false otherwise. | |
| Return non-zero if *op* is an asynchronous generator object, zero otherwise. |
Member
Author
There was a problem hiding this comment.
We say "true" and "false" in this file (see PyGen_Check* above), and I'd rather be consistent.
Co-authored-by: Victor Stinner <[email protected]>
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 20, 2025
(cherry picked from commit 2da7ecc) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-141789 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 20, 2025
(cherry picked from commit 2da7ecc) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-141790 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
added a commit
that referenced
this pull request
Nov 20, 2025
) gh-141004: Document missing generator APIs (GH-141409) (cherry picked from commit 2da7ecc) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
ZeroIntensity
added a commit
that referenced
this pull request
Nov 20, 2025
) gh-141004: Document missing generator APIs (GH-141409) (cherry picked from commit 2da7ecc) Co-authored-by: Peter Bierma <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
Co-authored-by: Victor Stinner <[email protected]>
ashm-dev
pushed a commit
to ashm-dev/cpython
that referenced
this pull request
Dec 8, 2025
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't do
PyAsyncGenASend_CheckExactin this one because I think that should just be deprecated.📚 Documentation preview 📚: https://cpython-previews--141409.org.readthedocs.build/en/141409/c-api/gen.html#c.PyGen_GetCode