[3.14] gh-135427: Fix DeprecationWarning for os.fork when run in threads with -Werror (GH-136796)#140191
Closed
gpshead wants to merge 1 commit intopython:3.14from
Closed
Conversation
…ds with -Werror (pythonGH-136796) Don't ignore errors raised by `PyErr_WarnFormat` in `warn_about_fork_with_threads` Instead, ignore the warnings in all test code that forks. (That's a lot of functions.) In `test_support`, make `ignore_warnings` a context manager (as well as decorator), and add a `message` argument to it. Also add a `ignore_fork_in_thread_deprecation_warnings` helper for the deadlock-in-fork warning.
This was referenced Oct 16, 2025
gpshead
requested review from
a team,
1st1,
asvetlov,
kumaraditya303,
rhettinger,
vsajip and
willingc
as code owners
gpshead
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
|
Should we backport this? Warnings changes in patch releases make it harder to update, and from comments like #135427 (comment) it sounds like it's important to fix this now. But, if you think it should get a backport, let's do it :) |
Member
Author
|
I don't think this one is actually urgent to backport. I'll close this, the PR is ready and can be resurrected if deemed important. So -Werror doesn't turn it into an error in 3.14 but we've fixed that in 3.15? good enough. This is an odd warning - it'll probably never become an error because our detection can only ever be best effort (it cannot be guaranteed to detect if other threads exist), it's more of the best way to surface an application design flaw to users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick fd8f42d for a backport to 3.14
Don't ignore errors raised by
PyErr_WarnFormatinwarn_about_fork_with_threadsInstead, ignore the warnings in all test code that forks. (That's a lot of functions.)In
test_support, makeignore_warningsa context manager (as well as decorator), and add amessageargument to it.Also add a
ignore_fork_in_thread_deprecation_warningshelper for the deadlock-in-fork warning.