bpo-35621: Fix tests when SafeChildWatcher is expected instead of ThreadedChildWatcher#13754
Merged
miss-islington merged 3 commits intopython:masterfrom Jun 2, 2019
Merged
Conversation
Member
|
This is failing for me because there is no event loop in the thread that executes |
pablogsal
reviewed
Jun 2, 2019
| def test_get_child_watcher_thread(self): | ||
|
|
||
| def f(): | ||
| policy.set_event_loop(policy.new_event_loop()) |
Member
There was a problem hiding this comment.
What about:
def f():
policy.set_event_loop(policy.new_event_loop())
policy.set_child_watcher(asyncio.SafeChildWatcher())
Contributor
Author
There was a problem hiding this comment.
Changed to keep policy.set_event_loop() in a thread but setup the watcher in the main thread (it is crucial for the test).
pablogsal
approved these changes
Jun 2, 2019
Member
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
I tested it locally and get no failures anymore :)
Contributor
Author
|
Thanks @pablogsal |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35621