GH-136874: url2pathname(): discard query and fragment components#136875
Merged
barneygale merged 2 commits intopython:mainfrom Jul 21, 2025
Merged
GH-136874: url2pathname(): discard query and fragment components#136875barneygale merged 2 commits intopython:mainfrom
url2pathname(): discard query and fragment components#136875barneygale merged 2 commits intopython:mainfrom
Conversation
In `urllib.request.url2pathname()`, ignore any query or fragment components in the given URL.
Contributor
Author
|
@hugovk is this OK to backport into 3.14 once approved? It's somewhere between a bugfix and a feature enhancement I think. (3.14 contains a bevy of related improvements to |
Member
As a feature, no; as a bugfix, yes. So you can merge and backport as a bugfix, if done before tomorrow morning for RC1. |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
…nts (pythonGH-136875) In `urllib.request.url2pathname()`, ignore any query or fragment components in the given URL. (cherry picked from commit 80b2d60) Co-authored-by: Barney Gale <[email protected]>
|
GH-136942 is a backport of this pull request to the 3.14 branch. |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…nts (python#136875) In `urllib.request.url2pathname()`, ignore any query or fragment components in the given URL.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…nts (python#136875) In `urllib.request.url2pathname()`, ignore any query or fragment components in the given URL.
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…components (pythonGH-136875) (python#136942) pythonGH-136874: `url2pathname()`: discard query and fragment components (pythonGH-136875) In `urllib.request.url2pathname()`, ignore any query or fragment components in the given URL. (cherry picked from commit 80b2d60) Co-authored-by: Barney Gale <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
urllib.request.url2pathname(), ignore any query or fragment components in the given URL.url2pathname()doesn't handle URL query or fragment components #136874📚 Documentation preview 📚: https://cpython-previews--136875.org.readthedocs.build/