Skip to content

gh-136421: Fix crash in _datetime when initialized/finalized concurrently #136620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neonene wants to merge 11 commits into from
Closed

gh-136421: Fix crash in _datetime when initialized/finalized concurrently #136620

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c6cdbe
NEWS
neonene Jul 13, 2025
c9ad7fa
Add a test
neonene Jul 13, 2025
61f1faf
Tweak test
neonene Jul 13, 2025
df7ae54
ditto
neonene Jul 13, 2025
6976252
ditto
neonene Jul 13, 2025
7d85f55
ditto
neonene Jul 13, 2025
3a6f844
Fix crash
neonene Jul 13, 2025
c3b3a35
Make test less expensive
neonene Jul 13, 2025
9cae616
Apply suggestions
neonene Jul 14, 2025
478a75e
Clarify comments
neonene Jul 14, 2025
790a034
reword
neonene Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ditto
  • Loading branch information
@neonene
neonene authored Jul 13, 2025
commit df7ae54c8c776262916b68a198b8be5262acda58
29 changes: 12 additions & 17 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7295,26 +7295,21 @@ def test_update_type_cache(self):
""")
script_helper.assert_python_ok('-c', script)

@support.skip_if_pgo_task
@unittest.skipIf(_interpreters is None, "missing _interpreters module")
def test_static_type_concurrent_init_fini(self):
# gh-136421
script = textwrap.dedent("""
import threading
import _interpreters

def run(id):
_interpreters.exec(id, "import _datetime; print('a', end='')")
_interpreters.destroy(id)

ids = [_interpreters.create() for i in range(10)]
ts = [threading.Thread(target=run, args=(id,)) for id in ids]
for t in ts:
t.start()
for t in ts:
t.join()
""")
res = script_helper.assert_python_ok('-c', script)
self.assertEqual(res.out, b'a' * 10)
from concurrent.futures import InterpreterPoolExecutor
def func():
import _datetime
print('a', end='')
with InterpreterPoolExecutor() as executor:
for _ in range(8):
executor.submit(func)
""")
_, out, err = script_helper.assert_python_ok("-c", script)
self.assertEqual(out, b'a' * 8)
self.assertEqual(err, b'')


def load_tests(loader, standard_tests, pattern):
Expand Down
Loading