Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@shihai1991, since this is a manual backport to 2.7, please preface the PR title with [2.7]. Thanks!

Also requesting review from @ncoghlan as he merged the pull request to master and 3.7.

@shihai1991, since this is a manual backport to 2.7, please preface the PR title with [2.7]. Thanks!

copy that.

I added my comment about removing too much info on the bpo issue, given that this is a backport PR so less appropriate for the discussion.

@ncoghlan answered on the original PR: #13087 (comment)

Which means: please go back to the original version. Sorry for the trouble!

A process note: rebases or force-pushes are not useful on CPython repo; there can be as many intermediary commits as needed, even with broken tests or docs, because we always do a squash merge in the end. Non-rewritten commits also work a lot better in github’s UI, which will show «changes since last time you viewed» for reviewers.

copy that, let me try it again.

@shihai1991: Status check is done, and it's a success ✅ .

Thanks for the backport!