Skip to content

bpo-35907: Clarify the NEWS entry#13523

Merged
vstinner merged 2 commits intopython:masterfrom
vstinner:local_file_news
May 24, 2019
Merged

bpo-35907: Clarify the NEWS entry#13523
vstinner merged 2 commits intopython:masterfrom
vstinner:local_file_news

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented May 23, 2019 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented May 23, 2019

Gregory commented my master PR:

"This text doesn't make sense as written. "as disallowing the unnecessary URL scheme" says nothing. WHAT url scheme did we just break our users applications by refusing to support? Those need to be listed in the NEWS entry."
https://github.com/python/cpython/pull/13474/files#r286726212

I wrote this PR to clarify which scheme is rejected.

@gpshead @tirkarthi @push0ebp: Would it sound better said like that?

Once this PR will be merged, I will also update the NEWS entry in 2.7 and 3.7, and then update my 3.5 and 3.6 backports.

@vstinner vstinner mentioned this pull request May 23, 2019
Merged
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented May 24, 2019

[whatsnew/changelog:12] "" found in "local_file://"

Oh, I made a typo. It's now fixed.

@vstinner vstinner merged commit deffee5 into python:master May 24, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 24, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 24, 2019

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker deffee57749cf29ba17f50f11fb2a8cbc3e3752d 3.7

@vstinner vstinner deleted the local_file_news branch May 24, 2019 20:11
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-35907: Clarify the NEWS entry (pythonGH-13523)
6d68f60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot