gh-127604: ensure -ldl is passed to the linker when dladdr1 is found#133040
gh-127604: ensure -ldl is passed to the linker when dladdr1 is found#133040picnixz merged 7 commits intopython:mainfrom
-ldl is passed to the linker when dladdr1 is found#133040Conversation
-ldl is passed to the linker when dladdr1 is found-ldl is passed to the linker when dladdr1 is found
ZeroIntensity
left a comment
There was a problem hiding this comment.
LGTM, but let's run buildbots to make sure we didn't break anything.
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 3d22310 🤖 Results will be shown at: If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
|
@picnixz This seems to have resulted in the |
|
Looks like it's not just macOS and iOS; Ubuntu builds now include compilation statements like |
|
Aaaaaah I don't understand:( Why would it include it twice I'll investigate |
|
Mmh, it's actually in Python/traceback.c. A bit more annoying. |
|
Hum. I also forgot removing |
|
faulthandler is built as a built-in module, since Py_FatalError() uses it (dump the backtrace and than turns off faulthandler). |
|
I found the issue. Because of |
|
PR is ready: #133071.
And yes, that's why I didn't see the warnings. I use gcc and not clang |
|
I was wondering if autoreconf was smart enough to deal with the extra flags. Buildbots passed so I figured it was ok :(. |
See https://man7.org/linux/man-pages/man3/dladdr.3.html#LIBRARY for details.
faulthandler#127604