Skip to content

gh-130931: Add PyFrame_SetBack() function#131252

Closed
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:frame_setback
Closed

gh-130931: Add PyFrame_SetBack() function#131252
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:frame_setback

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 14, 2025 •
edited by github-actions Bot
Loading

@vstinner
pythongh-130931: Add PyFrame_SetBack() function
062591a 
Add tests on PyFrame_GetBack() and PyFrame_SetBack().
@vstinner vstinner requested a review from markshannon as a code owner March 14, 2025 16:06
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2025
Open
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 18, 2025

The coroutine support then needs to inject frames into the current stack. For this, we currently read and write f_back:
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L784-L831
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L870-L897

@da-woods: Would this function PyFrame_SetBack() be useful to Cython?

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 19, 2025

cc @markshannon

@da-woods
Copy link
Copy Markdown
Contributor

da-woods commented Mar 19, 2025

It'd work for us for our coroutine usage, but from what Mark said, it sounds like there might be issues exposing it more generally.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 20, 2025 •
edited
Loading

@markshannon is against this API: #130931 (comment). So I prefer to close my PR.

@vstinner vstinner closed this Mar 20, 2025
@vstinner vstinner deleted the frame_setback branch March 20, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @da-woods