gh-128067: Add newline to new REPL output when needed to avoid chopping characters#131011
Closed
devdanzin wants to merge 1 commit intopython:mainfrom
Closed
gh-128067: Add newline to new REPL output when needed to avoid chopping characters#131011devdanzin wants to merge 1 commit intopython:mainfrom
devdanzin wants to merge 1 commit intopython:mainfrom
Conversation
… in the same line as last output.
Member
Author
|
This approach has many downsides and corner cases, closing to avoid wasting reviewer's time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #128067 (and #128809) by capturing REPL output into a
StringIO, checking whether it ends in a newline and adding one if necessary. Works on Windows and Linux.Before:
After:
Feel free to suggest improvements. If this approach doesn't make sense, I have no great attachment to this PR.