GH-107956: install build-details.json (PEP 739)#130069
Merged
FFY00 merged 11 commits intopython:mainfrom Feb 13, 2025
Merged
Conversation
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
|
Member
Author
|
The buildbot failure seems unrelated. |
colesbury
reviewed
Feb 14, 2025
| exit 1 ; \ | ||
| fi | ||
|
|
||
| build-details.json: pybuilddir.txt |
Contributor
There was a problem hiding this comment.
The target path here is wrong so this gets re-run for every invocation of make.
rgommers
reviewed
Oct 24, 2025
| # | ||
| # We only want to set abi.extension_suffix and stable_abi_suffix if | ||
| # extension modules are supported. | ||
| if has_dynamic_library: |
Contributor
There was a problem hiding this comment.
This logic is wrong. Whether libpython.so is shipped and must be linked against is very much not the same as whether extension modules are supported. The default builds on Linux and macOS do not require linking against libpython. On a regular 3.14 install on 64-bit Linux:
>>> import sysconfig
>>> sysconfig.get_config_var('LDLIBRARY')
'libpython3.14t.a'
>>> sysconfig.get_config_var('LIBPYTHON')
''I'll open a new issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.