gh-128066: Fixed PyREPL history saving on read-only file systems#128088
gh-128066: Fixed PyREPL history saving on read-only file systems#128088vladimir-poghosyan wants to merge 7 commits intopython:mainfrom vladimir-poghosyan:fix-issue-128066
Conversation
Co-authored-by: Sergey B Kirpichev <[email protected]>
skirpichev
left a comment
There was a problem hiding this comment.
LGTM in general, with few concerns.
- Maybe it worth a test.
- I worry, that error is too late. Though, this will be fixed by #132294.
|
Thank you for reviewing the PR. I looked through your mentioned pull request an noticed that the call to Will it be better, that I add |
Now I also catch
Hmm, maybe. (BTW I doubt that |
|
I've changed my implementation and moved error handling to the |
|
Closing in favor of #134380. |
As suggested in the comment of the linked issue by @ZeroIntensity, I simply handled the exception with a resulting warning.