bpo-36583: Do not swallow exceptions in the _ssl module.#12756
bpo-36583: Do not swallow exceptions in the _ssl module.#12756serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
|
I think the relevant issue is https://bugs.python.org/issue36583 ? https://bugs.python.org/issue339827 returns 404 but @bedevere-bot seems to have accepted it. Seems to be known issue : python/bedevere#15 |
serhiy-storchaka
changed the title
|
Thanks @tirkarthi. I have no idea from where this number came. I just pasted it from the clipboard, but seems something messed. |
| PyObject *cadata_ascii = NULL; | ||
|
|
||
| if (PyObject_GetBuffer(cadata, &buf, PyBUF_SIMPLE) == 0) { | ||
| if (PyUnicode_Check(cadata)) { |
There was a problem hiding this comment.
Why did you change the order of checks here? What was wrong with the original code?
There was a problem hiding this comment.
Nothing wrong, but it seems to me that checking for unicode string prior to checking for bytes-like objects is more common. If you prefer, I'll return the former order. This will minimize the diff.
6 participants
https://bugs.python.org/issue36583