[3.12] gh-126565: Skip zipfile.Path.exists check in write mode (GH-126576)#126643
Merged
jaraco merged 1 commit intopython:3.12from Nov 10, 2024
Merged
[3.12] gh-126565: Skip zipfile.Path.exists check in write mode (GH-126576)#126643jaraco merged 1 commit intopython:3.12from
zipfile.Path.exists check in write mode (GH-126576)#126643jaraco merged 1 commit intopython:3.12from
Conversation
…onGH-126576) When `zipfile.Path.open` is called, the implementation will check whether the path already exists in the ZIP file. However, this check is only required when the ZIP file is in read mode. By swapping arguments of the `and` operator, the short-circuiting will prevent the check from being run in write mode. This change will improve the performance of `open()`, because checking whether a file exists is slow in write mode, especially when the archive has many members. (cherry picked from commit 160758a) Co-authored-by: Jan Hicken <[email protected]>
jaraco
approved these changes
Nov 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
zipfile.Path.openis called, the implementation will checkwhether the path already exists in the ZIP file. However, this check is
only required when the ZIP file is in read mode. By swapping arguments
of the
andoperator, the short-circuiting will prevent the check frombeing run in write mode.
This change will improve the performance of
open(), because checkingwhether a file exists is slow in write mode, especially when the archive
has many members.
(cherry picked from commit 160758a)
Co-authored-by: Jan Hicken [email protected]