Doc: Use major.minor for documentation distribution archive filenames#124489
Merged
AA-Turner merged 2 commits intopython:mainfrom Sep 25, 2024
Merged
Doc: Use major.minor for documentation distribution archive filenames#124489AA-Turner merged 2 commits intopython:mainfrom
major.minor for documentation distribution archive filenames#124489AA-Turner merged 2 commits intopython:mainfrom
Conversation
AA-Turner
added
docs
Member
|
The file names don't seem to have been changed with the current version of the PR (see the RTD preview index page)? |
Member
Author
Do you mean https://cpython-previews--124489.org.readthedocs.build/en/124489/download.html? This is linked to the static release files uploaded by RMs, it's only the daily builds (run with A |
Member
|
Doh! |
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2024
…ames (pythonGH-124489) (cherry picked from commit 6318ffc) Co-authored-by: Adam Turner <[email protected]>
|
GH-124534 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2024
…ames (pythonGH-124489) (cherry picked from commit 6318ffc) Co-authored-by: Adam Turner <[email protected]>
|
GH-124535 is a backport of this pull request to the 3.12 branch. |
AA-Turner
added a commit
that referenced
this pull request
Sep 25, 2024
…e filenames (GH-124489) (#124535) Doc: Use ``major.minor`` for documentation distribution archive filenames (GH-124489) (cherry picked from commit 6318ffc) Co-authored-by: Adam Turner <[email protected]>
emilyemorehouse
added a commit
to lysnikolaou/cpython
that referenced
this pull request
Sep 26, 2024
* main: (69 commits) Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566) pythongh-124412: Add helpers for converting annotations to source format (python#124551) pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561) For-else deserves its own section in the tutorial (python#123946) Add 3.13 as a version option to the crash issue template (python#124560) pythongh-123242: Note that type.__annotations__ may not exist (python#124557) pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479) pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227) pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752) pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856) pythongh-124370: Add "howto" for free-threaded Python (python#124371) pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278) pythongh-119400: make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400 (pythonGH-119401) pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337) pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449) pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490) pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542) pythongh-124513: Check args in framelocalsproxy_new() (python#124515) pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480) Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489) ...
Yhg1s
pushed a commit
that referenced
this pull request
Sep 26, 2024
…e filenames (GH-124489) (#124534) Doc: Use ``major.minor`` for documentation distribution archive filenames (GH-124489) (cherry picked from commit 6318ffc) Co-authored-by: Adam Turner <[email protected]>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per python/docs-community#131, this adjusts the documentation archive filenames to only include "major.minor".
Ned outlines a key motivating point:
By just using
x.ywe are honest that the download reflects the state of the website rather than any one release -- for that, use https://docs.python.org/release/.This patch changes
patchlevel.pyto return themajor.minorversion rather than the full release version. This is picked up in the Makefile as$(DISTVERSION)and interpolated into the filenames.A
📚 Documentation preview 📚: https://cpython-previews--124489.org.readthedocs.build/