bpo-36365: Rewrite structseq_repr() using _PyUnicodeWriter#12440
Merged
vstinner merged 2 commits intopython:masterfrom Mar 19, 2019
vstinner:structseq_writer
Merged
bpo-36365: Rewrite structseq_repr() using _PyUnicodeWriter#12440vstinner merged 2 commits intopython:masterfrom vstinner:structseq_writer
vstinner merged 2 commits intopython:masterfrom
vstinner:structseq_writer
Conversation
No longer limit repr(structseq) to 512 bytes. Use _PyUnicodeWriter for better performance and write directly Unicode rather than using encode repr() value to UTF-8 and then decode from UTF-8.
| strlen(typ->tp_name), | ||
| NULL); | ||
| if (type_name == NULL) { | ||
| goto error; |
Contributor
There was a problem hiding this comment.
For the record, this goto error would cause _PyUnicodeWriter_Dealloc() to be called on an uninitialized _PyUnicodeWriter. This was fixed in 93e8012.
Member
Author
Oops, I moved "PyObject *type_name = ..." after my initial code to simplify the error handling, but I forgot to make the error handling correct in the final change. So thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer limit repr(structseq) to 512 bytes. Use _PyUnicodeWriter
for better performance and write directly Unicode rather than using
encode repr() value to UTF-8 and then decode from UTF-8.
https://bugs.python.org/issue36365