bpo-36235: Enhance distutils test_customize_compiler()#12403
Merged
vstinner merged 1 commit intopython:masterfrom Mar 18, 2019
vstinner:customize_compiler_test
Merged
bpo-36235: Enhance distutils test_customize_compiler()#12403vstinner merged 1 commit intopython:masterfrom vstinner:customize_compiler_test
vstinner merged 1 commit intopython:masterfrom
vstinner:customize_compiler_test
Conversation
The test test_customize_compiler() now mocks all sysconfig variables and all environment variables used by customize_compiler().
eamanu
approved these changes
Mar 18, 2019
Contributor
eamanu
left a comment
eamanu
left a comment
There was a problem hiding this comment.
LGTM. I test on Ubuntu 18.04
yan12125
added a commit
to archlinuxcn/repo
that referenced
this pull request
Mar 18, 2019
vstinner
added a commit
that referenced
this pull request
Mar 18, 2019
vstinner
added a commit
that referenced
this pull request
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test test_customize_compiler() now mocks all sysconfig variables
and all environment variables used by customize_compiler().
https://bugs.python.org/issue36235