Skip to content

[3.6] bpo-34745: Fix asyncio sslproto memory issues (GH-12386)#12393

Closed
fantix wants to merge 1 commit intopython:3.6from
fantix:fix-sslproto-handshake-timeout-leak
Closed

[3.6] bpo-34745: Fix asyncio sslproto memory issues (GH-12386)#12393
fantix wants to merge 1 commit intopython:3.6from
fantix:fix-sslproto-handshake-timeout-leak

Conversation

@fantix
Copy link
Copy Markdown
Contributor

@fantix fantix commented Mar 18, 2019

  • Fix handshake timeout leak in asyncio/sslproto, refs Fixes #220 sslproto memory issue MagicStack/uvloop#222
  • Break circular ref _SSLPipe <-> SSLProtocol
  • bpo-34745: Fix asyncio ssl memory leak
  • Break circular ref SSLProtocol <-> UserProtocol
  • Add NEWS entry
  • Dropped unit test whose base test is missing in 3.6 <-- Please kindly suggest

(cherry picked from commit f683f46)

https://bugs.python.org/issue34745

https://bugs.python.org/issue34745

* Fix handshake timeout leak in asyncio/sslproto, refs MagicStack/uvloop#222

* Break circular ref _SSLPipe <-> SSLProtocol

* bpo-34745: Fix asyncio ssl memory leak

* Break circular ref SSLProtocol <-> UserProtocol

* Add NEWS entry
@1st1
Copy link
Copy Markdown
Member

1st1 commented Mar 18, 2019

Dropped unit test whose base test is missing in 3.6 <-- Please kindly suggest

Can't we backport it?

@fantix
Copy link
Copy Markdown
Contributor Author

fantix commented Mar 18, 2019

For some reason, a lot of sslproto test code is missing on 3.6. Let me try to backport all of them later today.

@1st1
Copy link
Copy Markdown
Member

1st1 commented Mar 18, 2019

Oh, it's fine then, I'll merge as is.

@1st1
Copy link
Copy Markdown
Member

1st1 commented Mar 18, 2019

Hm, I guess only release manager can merge this in 3.6 now...

@ned-deily
Copy link
Copy Markdown
Member

3.6 is now in security-fix only support mode. As it does not appear that this change meets the criteria for inclusion in a security-fix-only branch, I am closing the PR.

@ned-deily ned-deily closed this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants