bpo-34745: Fix asyncio sslproto memory issues#12386
Merged
1st1 merged 4 commits intopython:masterfrom Mar 17, 2019
Merged
Conversation
* Break circular ref SSLProtocol <-> UserProtocol
1st1
approved these changes
Mar 17, 2019
Contributor
|
GH-12387 is a backport of this pull request to the 3.7 branch. |
Contributor
|
Sorry, @fantix and @1st1, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2019
* Fix handshake timeout leak in asyncio/sslproto Refs MagicStack/uvloopGH-222 * Break circular ref _SSLPipe <-> SSLProtocol * bpo-34745: Fix asyncio ssl memory leak * Break circular ref SSLProtocol <-> UserProtocol * Add NEWS entry (cherry picked from commit f683f46) Co-authored-by: Fantix King <[email protected]>
Member
|
@fantix Could you please make a pr against 3.6? |
Contributor
Author
|
@1st1 sure thing, thanks for the quick response! |
miss-islington
added a commit
that referenced
this pull request
Mar 17, 2019
* Fix handshake timeout leak in asyncio/sslproto Refs MagicStack/uvloopGH-222 * Break circular ref _SSLPipe <-> SSLProtocol * bpo-34745: Fix asyncio ssl memory leak * Break circular ref SSLProtocol <-> UserProtocol * Add NEWS entry (cherry picked from commit f683f46) Co-authored-by: Fantix King <[email protected]>
fantix
added a commit
to fantix/cpython
that referenced
this pull request
Mar 18, 2019
* Fix handshake timeout leak in asyncio/sslproto, refs MagicStack/uvloop#222 * Break circular ref _SSLPipe <-> SSLProtocol * bpo-34745: Fix asyncio ssl memory leak * Break circular ref SSLProtocol <-> UserProtocol * Add NEWS entry
|
GH-12393 is a backport of this pull request to the 3.6 branch. |
|
Hi guys, sorry for reopening such an old issue. I'm just playing with asyncio+ssl. Thanks a lot, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These issues are not strictly memory leaks, but they do affect the memory footprint and garbage collection if called frequently.
_SSLPipeandSSLProtocolSSLProtocolandUserProtocolhttps://bugs.python.org/issue34745
Before the fix:
After the fix: