Skip to content

[3.7] bpo-36234: Add more tests to PosixUidGidTests (GH-12234)#12274

Merged
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-876e82b-3.7
Mar 11, 2019
Merged

[3.7] bpo-36234: Add more tests to PosixUidGidTests (GH-12234)#12274
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-876e82b-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Mar 11, 2019

test_posix.PosixUidGidTests:

  • Add tests for invalid uid/gid type (str)
  • Add UID_OVERFLOW and GID_OVERFLOW constants to replace (1 << 32)

Initial patch written by David Malcolm.

Co-Authored-By: David Malcolm [email protected]
(cherry picked from commit 876e82b)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue36234

test_posix.PosixUidGidTests:

* Add tests for invalid uid/gid type (str)
* Add UID_OVERFLOW and GID_OVERFLOW constants to replace (1 << 32)

Initial patch written by David Malcolm.

Co-Authored-By: David Malcolm <[email protected]>
(cherry picked from commit 876e82b)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 24872e1 into python:3.7 Mar 11, 2019
@miss-islington miss-islington deleted the backport-876e82b-3.7 branch March 11, 2019 13:18
@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants