Skip to content

bpo-36236: Set a fatal error if the current path cannot be obtained#12237

Closed
pablogsal wants to merge 2 commits intopython:masterfrom
pablogsal:bpo36236
Closed

bpo-36236: Set a fatal error if the current path cannot be obtained#12237
pablogsal wants to merge 2 commits intopython:masterfrom
pablogsal:bpo36236

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Mar 8, 2019 •
edited by bedevere-bot
Loading

@tirkarthi
Copy link
Copy Markdown
Member

tirkarthi commented Mar 9, 2019

This might have a news entry since this crashes the interpreter on Mac OS while executing python -m module_name from a deleted directory.

@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Mar 9, 2019 •
edited
Loading

@vstinner Not sure what is the best way to use _Py_INIT_USER_ERR here as this function (_PyPathConfig_ComputeArgv0) returns a Pyobject*.

Nevermind, I have modified the function to take a PyObject** as third argument and return a _PyInitError :)

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Mar 12, 2019

I don't think that the fix is correct: https://bugs.python.org/issue36236#msg337767

@pablogsal pablogsal closed this Mar 19, 2019
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Mar 19, 2019

Superseded by #12424

@pablogsal pablogsal deleted the bpo36236 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @tirkarthi @vstinner @the-knights-who-say-ni @bedevere-bot