Skip to content

Comments

bpo-33944: Add site.py debugging via PYTHONSITEDEBUG#12107

Closed
native-api wants to merge 3 commits intopython:mainfrom
native-api:startup_debug
Closed

bpo-33944: Add site.py debugging via PYTHONSITEDEBUG#12107
native-api wants to merge 3 commits intopython:mainfrom
native-api:startup_debug

Conversation

@native-api
Copy link
Contributor

@native-api native-api commented Feb 28, 2019 •
edited by bedevere-bot
Loading

methane
methane reviewed Mar 2, 2019
View reviewed changes
@native-api native-api changed the title bpo-33944: Add site.py debugging via PYTHODSITEDEBUG bpo-33944: Add site.py debugging via PYTHONSITEDEBUG Mar 2, 2019
tiran
tiran requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR piggybacks on BPO 33944. IMO it needs a separate BPO and a more thorough discussion.

Lib/site.py
import _sitebuiltins


if os.environ.get("PYTHONSITEDEBUG", ""):
Copy link
Member

@tiran tiran Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any PYTHON env var must be ignored when ignore environment is set.

Suggested change
if os.environ.get("PYTHONSITEDEBUG", ""):
if not sys.flags.ignore_environment and os.environ.get("PYTHONSITEDEBUG"):

Doc/using/cmdline.rst
at the start of the :mod:`site` module.
This is useful to diagnose issues in 3rd-party code that runs at startup.

.. versionadded:: 3.8
Copy link
Member

@tiran tiran Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 3.8
.. versionadded:: 3.10

@bedevere-bot
Copy link

bedevere-bot commented Jun 16, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jan 15, 2024

Closed as per #12107 (review)

@warsaw warsaw mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

@tiran tiran tiran requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@native-api @bedevere-bot @erlend-aasland @methane @tiran @the-knights-who-say-ni @ezio-melotti