Skip to content

gh-117683: Fix test_free_different_thread failures with GIL disabled#117685

Merged
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-117683-test_free_different_thread
Apr 16, 2024
Merged

gh-117683: Fix test_free_different_thread failures with GIL disabled#117685
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-117683-test_free_different_thread

Conversation

@colesbury
Copy link
Copy Markdown
Contributor

@colesbury colesbury commented Apr 9, 2024

Fix occasional test failures when the GIL is disabled by weakening the assertion in ThreadTest.

@colesbury colesbury requested a review from DinoV April 15, 2024 18:14
Copy link
Copy Markdown
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury colesbury merged commit df0f3a7 into python:main Apr 16, 2024
@colesbury colesbury deleted the gh-117683-test_free_different_thread branch April 16, 2024 15:56
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants