gh-67224: Make linecache imports relative to improve startup speed#117501
Merged
pablogsal merged 2 commits intopython:mainfrom Apr 10, 2024
Merged
gh-67224: Make linecache imports relative to improve startup speed#117501pablogsal merged 2 commits intopython:mainfrom
pablogsal merged 2 commits intopython:mainfrom
Conversation
vstinner
reviewed
Apr 3, 2024
Member
Author
|
Oh man, seems this is complicated because making the import lazy actually fails at shutdown because if the first time this is called its when the interpreter is shutting down, sys.meta_path is None :( |
Member
Author
|
Well, I think this should do the trick |
vstinner
reviewed
Apr 3, 2024
vstinner
reviewed
Apr 3, 2024
Signed-off-by: Pablo Galindo <[email protected]>
vstinner
approved these changes
Apr 3, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Just a suggestion to reorganize checkcache() import/except ImportError.
pablogsal
commented
Apr 10, 2024
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Apr 16, 2024
pythongh-117501 put some code before the docstring, so now it is no longer recognized as a docstring.
| import os | ||
| import sys | ||
|
|
||
| """Update a cache entry and return its list of lines. |
Member
There was a problem hiding this comment.
We lost the docstring because you put the imports before it. Filed #117948 to fix this.
hauntsaninja
pushed a commit
that referenced
this pull request
Apr 16, 2024
gh-117501 put some code before the docstring, so now it is no longer recognized as a docstring.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
pythongh-117501 put some code before the docstring, so now it is no longer recognized as a docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.