gh-115124: Use _PyObject_ASSERT() in gc.c#115125
Conversation
|
!buildbot Windows11 Bigmem |
|
AMD64 Windows11 Bigmem PR job: https://buildbot.python.org/all/#/builders/1088/builds/308 |
vstinner
force-pushed
the
gc_assert
branch
2 times, most recently
from
2b625c7 to
3f8a768
Compare
|
@pablogsal: I rebased my PR. Would you mind to review the change? |
|
@colesbury @nascheme: Would you mind to review this change? |
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
There's a compiler warning, but otherwise LGTM
Python/gc.c
Outdated
| next isn't, so they can't | ||
| be the same */ | ||
| // wrasgc is reachable, but next isn't, so they can't be the same | ||
| _PyObject_ASSERT(wr, wrasgc != next); |
There was a problem hiding this comment.
There's a GitHub actions warning: I think this needs a (PyObject *) cast on wr.
There was a problem hiding this comment.
Alright, I missed that warning. It's now fixed.
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM modulo the compiler warning
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
|
@colesbury @pablogsal: Thanks for reviews. I rebased my PR on main, fixed the compiler warning, and enabled "auto-merge". |
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
4 participants
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.