bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels#11214
bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels#11214miss-islington merged 11 commits intopython:masterfrom
Conversation
* Change text for Code Context to toggle between Show Code Context and Hide Code Context based on whether code context is active for the window. * Move Zoom Height under Options menu.
|
I deleted multiple comments about not being able to do any edit actions. It turn out to be a problem with github on current Firefox. I tried MS Edge and everything works. |
Add Zoom Height change.
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Looks nice. Consider changes. Otherwise, approve.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
* Reverse Zoom Height and Code Context on options menu. * Alter between Zoom/Restore Zoom Height menu label. * Change indexing on menu item names.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
Adjust blurb for latest patch.
terryjreedy
changed the title
|
@csabella: Status check is done, and it's a failure ❌ . |
|
@csabella: Status check is done, and it's a success ✅ . |
|
Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11286 is a backport of this pull request to the 3.7 branch. |
…thonGH-11214) The Code Context menu label now toggles between Show/Hide Code Context. The Zoom Height menu now toggles between Zoom/Restore Height. Zoom Height has moved from the Window menu to the Options menu. https://bugs.python.org/issue22703 (cherry picked from commit c1b4b0f) Co-authored-by: Cheryl Sabella <[email protected]>
…-11214) The Code Context menu label now toggles between Show/Hide Code Context. The Zoom Height menu now toggles between Zoom/Restore Height. Zoom Height has moved from the Window menu to the Options menu. https://bugs.python.org/issue22703 (cherry picked from commit c1b4b0f) Co-authored-by: Cheryl Sabella <[email protected]>
5 participants
The Code Context menu label now toggles between Show/Hide Code Context.
The Zoom Height menu now toggles between Zoom/Restore Height.
Zoom Height has moved from the Window menu to the Options menu.
https://bugs.python.org/issue22703