Skip to content

gh-109739: regrtest disables load tracker if refleak#109871

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:regrtest_load_tracker
Sep 26, 2023
Merged

gh-109739: regrtest disables load tracker if refleak#109871
vstinner merged 1 commit intopython:mainfrom
vstinner:regrtest_load_tracker

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Sep 25, 2023 •
edited by bedevere-app Bot
Loading

Disable the Windwos load tracker when hunting reference leak.

@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2023
Closed
@vstinner vstinner force-pushed the regrtest_load_tracker branch from 10b0d91 to 9fdae73 Compare September 25, 2023 22:15
@vstinner vstinner enabled auto-merge (squash) September 25, 2023 22:23
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 25, 2023

Windows x64 failed: issue #109401

ERROR: test_default_timeout (test.test_threading.BarrierTests.test_default_timeout)

@vstinner vstinner disabled auto-merge September 26, 2023 00:09
@vstinner vstinner force-pushed the regrtest_load_tracker branch from 9fdae73 to d3a0ac9 Compare September 26, 2023 00:10
@vstinner
pythongh-109739: regrtest disables load tracker if refleak
582f4bd 
regrtest: Fix reference leak check on Windows. Disable the load
tracker on Windows in the reference leak check mode (-R option).
@vstinner vstinner force-pushed the regrtest_load_tracker branch from d3a0ac9 to 582f4bd Compare September 26, 2023 00:10
@vstinner vstinner enabled auto-merge (squash) September 26, 2023 00:10
@vstinner vstinner disabled auto-merge September 26, 2023 00:10
@vstinner vstinner enabled auto-merge (squash) September 26, 2023 00:10
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Sep 26, 2023

macOS failed: test.test_concurrent_futures.test_deadlock failed (env changed): issue gh-109832.

Windows x64 failed again: it's a new issue, issue gh-109878, see below:

FAIL: test_wait_for_timeout_less_then_0_or_0_coroutine_do_not_started (test.test_asyncio.test_waitfor.AsyncioWaitForTest.test_wait_for_timeout_less_then_0_or_0_coroutine_do_not_started)
(...)
AssertionError: 0.1879999999998745 not less than 0.1

@vstinner vstinner merged commit 4091deb into python:main Sep 26, 2023
@vstinner vstinner deleted the regrtest_load_tracker branch September 26, 2023 01:05
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 26, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit 4091deb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/540/builds/6633) and take a look at the build logs.
  4. Check if the failure is related to this commit (4091deb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/540/builds/6633

Failed tests:

  • test_tools

Failed subtests:

  • test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/test/test_tools/test_freeze.py", line 32, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 146, in prepare
    copy_source_tree(srcdir, SRCDIR)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Tools/freeze/test/freeze.py", line 95, in copy_source_tree
    shutil.copytree(oldroot, newroot, ignore=ignore_non_src)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/shutil.py", line 588, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Lib/shutil.py", line 542, in _copytree
    raise Error(errors)
shutil.Error: [('/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/build/test_python_44669æ/@test_44669_tmpæ/brokenLinkLoop', '/tmp/test_python_agyxig8m/tmpjzcaj6lc/cpython/build/test_python_44669æ/@test_44669_tmpæ/brokenLinkLoop', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/build/test_python_44669æ/@test_44669_tmpæ/brokenLinkLoop'"), (<DirEntry '@test_44669_tmpæ'>, '/tmp/test_python_agyxig8m/tmpjzcaj6lc/cpython/build/test_python_44669æ/@test_44669_tmpæ', "[Errno 2] No such file or directory: '/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/build/test_python_44669æ/@test_44669_tmpæ'")]

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 26, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 4091deb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/5042) and take a look at the build logs.
  4. Check if the failure is related to this commit (4091deb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/5042

Failed tests:

  • test_eintr

Failed subtests:

  • test_flock - main.FNTLEINTRTest.test_flock
  • test_all - test.test_eintr.EINTRTests.test_all

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_0a287f08'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_eintr.py", line 17, in test_all
    script_helper.run_test_script(script)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/support/script_helper.py", line 300, in run_test_script
    raise AssertionError(f"{name} failed")
AssertionError: script _test_eintr.py failed


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/_test_eintr.py", line 526, in test_flock
    self._lock(fcntl.flock, "flock")
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/_test_eintr.py", line 515, in _lock
    self.assertGreaterEqual(dt, self.sleep_time)
AssertionError: 0.19782951299566776 not greater than or equal to 0.2

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109739: regrtest disables load tracker if refleak (python#10…
8e7d778 
…9871)

regrtest: Fix reference leak check on Windows. Disable the load
tracker on Windows in the reference leak check mode (-R option).
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-109739: regrtest disables load tracker if refleak (python#10…
470adc5 
…9871)

regrtest: Fix reference leak check on Windows. Disable the load
tracker on Windows in the reference leak check mode (-R option).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @bedevere-bot